Collect totals in placeOrder when no paymentMethod provided by pmclain · Pull Request #18768 · magento/magento2

pmclain · 2018-10-23T12:39:57Z

Description (*)

Quote item values such as base_original_price are only populated during total
collection. Currently in QuoteManagement::placeOrder if $paymentMethod is
passed Payment::importData collects the quote totals to populate these values.

Payment methods like Auth.net DirectPost do pass a value for $paymentMethod
during order placement which causes order items to be converted with zero
values for the original_price attributes.

Fixed Issues (if relevant)

Authorize.net #16050 Authorize.net

Manual testing scenarios (*)

Enable Authorize.net Direct Post payment method
Add product to cart
Place order using Authorize.net Direct Post payment method
Open order detail view in admin panel
Order item original price should not be zero

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds on Travis CI are green)

Quote item values such as `base_original_price` are only populated during total collection. Currently in `QuoteManagement::placeOrder` if `$paymentMethod` is passed `Payment::importData` collects the quote totals to populate these values. Payment methods like Auth.net DirectPost do pass a value for `$paymentMethod` during order placement which causes order items to be converted with zero values for the `original_price` attributes. Fixes magento#16050

magento-engcom-team · 2018-10-23T12:40:07Z

Hi @pmclain. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento-engcom-team give me test instance - deploy test instance based on PR changes
@magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

…ded magento#18768

magento-engcom-team · 2018-10-24T15:06:28Z

Hi @slavvka, thank you for the review.
ENGCOM-3257 has been created to process this Pull Request

TomashKhamlai · 2018-11-01T09:57:50Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-11-01T09:57:52Z

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2018-11-01T09:58:27Z

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18768//admin
Login: admin Password: 123123q

TomashKhamlai · 2018-11-01T10:59:19Z

@magento-engcom-team indexer:reindex

TomashKhamlai · 2018-11-01T11:20:07Z

@magento-engcom-team give me 2.3-develop instance

magento-engcom-team · 2018-11-01T11:20:12Z

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.3-develop instance for you

magento-engcom-team · 2018-11-01T11:20:40Z

Hi @TomashKhamlai, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18768-2-3-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

TomashKhamlai · 2018-11-02T09:25:49Z

@magento-engcom-team give me 2.2-develop instance

magento-engcom-team · 2018-11-02T09:25:51Z

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento 2.2-develop instance for you

magento-engcom-team · 2018-11-02T09:26:24Z

Hi @TomashKhamlai, here is your Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/i-18768-2-2-develop//admin
Login: admin Password: 123123q
Instance will be terminated in up to 3 hours.

TomashKhamlai · 2018-11-02T13:16:16Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-11-02T13:16:22Z

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2018-11-02T13:17:04Z

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: http://ec2-34-228-235-121.compute-1.amazonaws.com/pr-18768//admin
Login: admin Password: 123123q

TomashKhamlai · 2018-12-05T11:15:09Z

@magento-engcom-team give me test instance

magento-engcom-team · 2018-12-05T11:15:12Z

Hi @TomashKhamlai. Thank you for your request. I'm working on Magento instance for you

magento-engcom-team · 2018-12-05T11:15:39Z

Hi @TomashKhamlai, here is your new Magento instance.
Admin access: https://pr-18768.instances.magento-community.engineering/admin
Login: admin Password: 123123q

magento-engcom-team · 2018-12-10T16:02:12Z

Hi @pmclain. Thank you for your contribution.
We will aim to release these changes as part of 2.3.1.
Please check the release notes for final confirmation.

…ded #18768

magento-engcom-team added Partner: Something Digital partners-contribution Pull Request is created by Magento Partner Component: Quote Release Line: 2.3 labels Oct 23, 2018

slavvka self-assigned this Oct 23, 2018

magento-engcom-team added this to the Release: 2.3.1 milestone Oct 23, 2018

ENGCOM-3257: Collect totals in placeOrder when no paymentMethod provi…

389a16b

…ded magento#18768

slavvka approved these changes Oct 24, 2018

View reviewed changes

magento-engcom-team added the Progress: accept label Dec 5, 2018

magento-engcom-team mentioned this pull request Dec 10, 2018

Authorize.net #16050

Closed

magento-engcom-team merged commit 389a16b into magento:2.3-develop Dec 10, 2018

magento-engcom-team added the Award: bug fix label Dec 10, 2018

magento-engcom-team pushed a commit that referenced this pull request Dec 10, 2018

ENGCOM-3257: Collect totals in placeOrder when no paymentMethod provi…

9e51141

…ded #18768

Conversation

pmclain commented Oct 23, 2018

Description (*)

Fixed Issues (if relevant)

Manual testing scenarios (*)

Contribution checklist (*)

Uh oh!

magento-engcom-team commented Oct 23, 2018

Uh oh!

magento-engcom-team commented Oct 24, 2018

Uh oh!

TomashKhamlai commented Nov 1, 2018

Uh oh!

magento-engcom-team commented Nov 1, 2018

Uh oh!

magento-engcom-team commented Nov 1, 2018

Uh oh!

TomashKhamlai commented Nov 1, 2018

Uh oh!

TomashKhamlai commented Nov 1, 2018

Uh oh!

magento-engcom-team commented Nov 1, 2018

Uh oh!

magento-engcom-team commented Nov 1, 2018

Uh oh!

TomashKhamlai commented Nov 2, 2018

Uh oh!

magento-engcom-team commented Nov 2, 2018

Uh oh!

magento-engcom-team commented Nov 2, 2018

Uh oh!

TomashKhamlai commented Nov 2, 2018

Uh oh!

magento-engcom-team commented Nov 2, 2018

Uh oh!

magento-engcom-team commented Nov 2, 2018

Uh oh!

TomashKhamlai commented Dec 5, 2018

Uh oh!

magento-engcom-team commented Dec 5, 2018

Uh oh!

magento-engcom-team commented Dec 5, 2018

Uh oh!

magento-engcom-team commented Dec 10, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants